search

xfra35 / f3-cron

Job scheduling for the PHP Fat-Free Framework
GNU General Public License v3.0
72 stars 22 forks source link

Update cron.php #12

Open slavino opened 2 years ago

slavino commented 2 years ago

adding date to cron.log -> cron_2022_01_19.log

adaniello commented 2 years ago

That way you would have n log files for n cron tasks. Only one log file with a good rotation policy is better

slavino commented 2 years ago

That way you would have n log files for n cron tasks. Only one log file with a good rotation policy is better

Only one file per day to my understanding of the proposed change. The log rotation is then extensible to compressing older files and also deleting very old files based on user's wish.

adaniello commented 2 years ago

Why not move the (optional) suffix in conf?

slavino commented 2 years ago

Why not move the (optional) suffix in conf?

Reflecting current implementation that would mean something like introducing new config option logFilename=dirname/cron_{{@(date'Y_m_d')}}.log

[CRON]
log = TRUE
logFilename=cronLogs/cron_{{ @(date'Y_m_d') }}.log

which would put your cron logs into F3 logs directory and it's subdir "cronLogs" and rolling once per day?

adaniello commented 2 years ago

@slavino I like that the user can be free to choose

slavino commented 2 years ago

Well then - the last proposal is 100% backward compatible and enables choice of time based rolling frequency via filename changes. What is the next step @xfra35 ?