Avoid using strncpy in InputText constructor

[coderabbitai[bot]]

The constructor in the InputText class uses strncpy, which can lead to buffer overflows. Consider using std::copy from the <algorithm> library to safely copy the string and ensure null termination.

Relevant code snippet:

#include <algorithm> // Include the algorithm library

InputText(ReactImgui* view, const int id, const std::string& defaultValue, const std::string& label, std::optional<BaseStyle>& style) : StyledWidget(view, id, style) {
    m_type = "InputText";
    m_bufferPointer = std::make_unique<char[]>(100);
    m_defaultValue = defaultValue;
    m_label = label;

    if (!defaultValue.empty()) {
        std::copy(defaultValue.c_str(), defaultValue.c_str() + std::min(defaultValue.size(), size_t(99)), m_bufferPointer.get());
        m_bufferPointer[std::min(defaultValue.size(), size_t(99))] = '\0'; // Ensure null termination
    }
}

References:

• https://cwe.mitre.org/data/definitions/676
• https://nvd.nist.gov/vuln/detail/CVE-2019-11365

PR URL: https://github.com/andreamancuso/react-wasm/pull/41 Comment URL: https://github.com/andreamancuso/react-wasm/pull/41#discussion_r1695145756