Feature/element styling state aware

andreamancuso commented 1 month ago

Summary by CodeRabbit

Release Notes

New Features
- Enhanced style management for UI elements, including new state tracking for hover, active, and focused states.
- Introduced a new property to track mouse click events within the Node component.
- Updated styles for tabs, including new properties for active and hovered states.
Bug Fixes
- Resolved visual issues with tab styles and hover effects.
Documentation
- Added comments to clarify style changes and temporary fixes.
Refactor
- Streamlined style extraction and application methods for improved performance.

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant changes to the dear-imgui package, primarily focusing on the styling and state management of UI elements. Key modifications include the introduction of new structs for style management, the renaming of member variables for clarity, and the addition of new methods for handling styles based on different states. The changes affect various components, including the Element, Node, and Widget classes, as well as several widget-related files, enhancing the overall styling flexibility and interaction state tracking.

Changes

File Path	Change Summary
`packages/dear-imgui/cpp/include/element/element.h`	- Replaced `BaseDrawStyle` with `ElementStyleParts` and added `ElementStyle` struct. - Introduced new methods: `HasStyle`, `GetElementStyleParts`, `ExtractStyle`. - Renamed `SetStyle` to `ApplyStyle`. - Added member variables for interaction states.
`packages/dear-imgui/cpp/src/element/element.cpp`	- Added `m_elementStyle` and new methods for style extraction and application. - Removed `SetStyle`, updated `DrawBaseEffects` and `Patch` methods to utilize new style handling logic.
`packages/dear-imgui/cpp/src/widget/widget.cpp`	- Updated `Widget` constructor to include `trackMouseClickEvents` parameter.
`packages/dear-imgui/ts/src/lib/components/ReactImgui/Node.tsx`	- Added `trackMouseClickEvents` property to `Node` component.
`packages/dear-imgui/ts/src/lib/components/ReactImgui/types.ts`	- Introduced `trackMouseClickEvents` to `NodeProps` type.
`packages/dear-imgui/ts/src/lib/components/TradingGuiDemo/Tabs/Tabs.tsx`	- Removed `font` property from tab styles and enhanced `hoveredTab` and `activeTab` styles with new properties.
`packages/dear-imgui/ts/src/lib/react-native/nativeFabricUiManager.ts`	- Updated `createNode` method to change ID linking logic from type-based to ID-based verification.

Possibly related PRs

#62: This PR introduces significant structural changes to the element.h file, including the replacement of BaseDrawStyle with ElementStyleParts, which aligns closely with the changes made in the main PR regarding style management and state handling in the Element class.

🐇 In the land of code where styles bloom,
New structs and methods make room!
With states to track and styles to apply,
Our UI now dances, oh my, oh my!
From buttons to tabs, all dressed in flair,
A rabbit's delight, with style everywhere! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.