The quest to reach feature parity between WASM and native Node module continues

andreamancuso commented 1 month ago

Still missing: images and maps (owing to being unable to fetch images from remote resources)

Summary by CodeRabbit

Release Notes

New Features
- Added support for optional asset base paths in ImGuiRenderer and ImPlotRenderer classes.
- Enhanced nodeImgui initialization with additional parameters for asset paths and font definitions.
- Introduced new submodules for improved Node.js integration.
Bug Fixes
- Improved thread safety in the PatchStyle method of the ReactImgui class.
Documentation
- Updated import paths for better organization in App.tsx.
Chores
- Updated package.json to allow flexible versions for react and react-dom.

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve the addition of two new submodules to the .gitmodules file, enhancing the project's dependency management. Modifications include updates to several classes, primarily in the ImGuiRenderer and ImPlotRenderer, to incorporate optional parameters for asset paths. The Button class saw the removal of debugging statements in its Measure method. Additionally, the Runner class was renamed from WasmRunner, and various methods were updated for improved functionality and parameter handling. The package.json was modified to allow for more flexible dependency versions.

Changes

File Path	Change Summary
`.gitmodules`	Added submodule `node-addon-api` and `node-api-headers` with respective URLs.
`packages/dear-imgui/cpp/app/include/imgui_renderer.h`	Updated constructor to include `std::optional<std::string>& basePath` and added `std::string m_assetsBasePath`.
`packages/dear-imgui/cpp/app/include/implot_renderer.h`	Updated constructor to include `std::optional<std::string> basePath`.
`packages/dear-imgui/cpp/app/include/widget/button.h`	Removed debugging `printf` statements from `Measure` method.
`packages/dear-imgui/cpp/app/src/imgui_renderer.cpp`	Updated constructor and font handling to use `m_assetsBasePath`.
`packages/dear-imgui/cpp/app/src/implot_renderer.cpp`	Updated constructor to pass `basePath` to `ImGuiRenderer`.
`packages/dear-imgui/cpp/app/src/reactimgui.cpp`	Added mutex locks in `PatchStyle` for thread safety and debug prints in `CalcTextSize`.
`packages/dear-imgui/cpp/deps/node-addon-api`	Added subproject commit identifier.
`packages/dear-imgui/cpp/deps/node-api-headers`	Added subproject commit identifier.
`packages/dear-imgui/cpp/node/CMakeLists.txt`	Added include directories and updated `NAPI_VERSION` definition.
`packages/dear-imgui/cpp/node/hello.cc`	Renamed `WasmRunner` to `Runner`, added new member variables and setter methods.
`packages/dear-imgui/cpp/wasm/src/main.cpp`	Updated `run` method and other functions to accept parameters by value.
`packages/dear-imgui/ts/node-imgui/TradingGuiDemo/CryptoSymbolPairs/CryptoSymbolPair.tsx`	Commented out `ReactImgui.Image` components for Bitcoin and Dollar logos.
`packages/dear-imgui/ts/node-imgui/index.tsx`	Added `fontDefs` and `assetsBasePath`, updated `nodeImgui.init()` call.
`packages/dear-imgui/ts/package.json`	Updated `peerDependencies` for `react` and `react-dom` to caret versions.
`packages/dear-imgui/ts/src/App.tsx`	Updated import path for `ReactImgui` component and reordered import statements.

Poem

In the garden of code, where rabbits play,
New paths for assets now light the way.
With optional strings, our classes now sing,
Debugging is simpler, oh what joy it brings!
So hop along, friends, let’s celebrate cheer,
For changes in code bring us all near! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.