Adding basic image support for desktop mode

andreamancuso commented 3 weeks ago

RenderDoc support:

Summary by CodeRabbit

New Features
- Enhanced image handling capabilities in the ReactImgui and ImGuiRenderer classes, including support for image job processing and texture management.
- Added new widget functionality for images in Emscripten environments.
- Introduced a new package configuration for dependency management.
- Updated image URLs in the CryptoSymbolPair component for better resource management.
Bug Fixes
- Improved error handling in image loading processes.
Documentation
- Updated .gitignore files to manage tracked files effectively.
Chores
- Restructured build configuration for improved dependency management and organization.
- Updated asset paths for better portability across environments.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The pull request introduces several changes across multiple files in the dear-imgui package. Key modifications include the adjustment of the .gitignore file to track .png files, the restructuring of CMakeLists.txt to manage source files and dependencies, and enhancements to various classes for improved image handling and rendering. Notable changes involve conditional compilation for Emscripten, the addition of new member variables and methods, and the introduction of a new JSON configuration for package management.

Changes

File Path	Change Summary
`packages/dear-imgui/assets/.gitignore`	Removed entry for ignoring all `.png` files, allowing them to be tracked by Git.
`packages/dear-imgui/cpp/app/CMakeLists.txt`	Added three source files (`reactimgui.cpp`, `imgui_renderer.cpp`, `implot_renderer.cpp`) to `REACT_IMGUI_SRC` and removed them from the end of the variable.
`packages/dear-imgui/cpp/app/include/imgui_renderer.h`	Moved `m_glfwWindow` from protected to public; updated `LoadTexture` method signatures based on Emscripten; added `HandleNextImageJob` method.
`packages/dear-imgui/cpp/app/include/reactimgui.h`	Added two member variables: `m_imageToTextureMap` and `m_imageJobs`.
`packages/dear-imgui/cpp/app/include/texture_helpers.h`	Introduced new structure `ImageJob` with members `widgetId` and `url`.
`packages/dear-imgui/cpp/app/include/widget/image.h`	Added methods for Emscripten: `QueueFetchImage`, `HandleFetchImageSuccess`, and `HandleFetchImageFailure`; updated `FetchImage` method signature.
`packages/dear-imgui/cpp/app/src/imgui_renderer.cpp`	Added `HandleNextImageJob` method; updated `LoadTexture` to differentiate Emscripten and non-Emscripten implementations.
`packages/dear-imgui/cpp/app/src/reactimgui.cpp`	Added OpenGL ES header; reinstated `widget/image.h` inclusion for Emscripten; modified `SetUpElementCreatorFunctions` to include `di-image` widget initialization.
`packages/dear-imgui/cpp/app/src/widget/checkbox.cpp`	Added include for `nlohmann/json.hpp`; modified `Checkbox::Patch` to update label from JSON.
`packages/dear-imgui/cpp/app/src/widget/image.cpp`	Updated rendering logic in `Render` method based on platform; modified `HandleInternalOp` to call `FetchImage` or `QueueFetchImage` based on platform.
`packages/dear-imgui/cpp/node/CMakeLists.txt`	Added dependencies for OpenGL, ada, and Stb; updated generator settings and source file inclusion.
`packages/dear-imgui/cpp/node/hello.cpp`	Implemented Singleton pattern in `Runner` class; renamed `run()` to `init()`; updated methods to interact with the Singleton instance.
`packages/dear-imgui/cpp/node/vcpkg.json`	Introduced new package configuration for `reactdearimgui` with dependencies on `stb`, `ada-url`, and `opengl-registry`.
`packages/dear-imgui/ts/.gitignore`	Added entry to ignore `imgui.ini` file.
`packages/dear-imgui/ts/node-imgui/TradingGuiDemo/CryptoSymbolPairs/CryptoSymbolPair.tsx`	Updated image URLs in `CryptoSymbolPair` component to relative paths and removed commented-out code.
`packages/dear-imgui/ts/node-imgui/index.tsx`	Changed `assetsBasePath` from an absolute Windows path to a relative path.

Possibly related PRs

#61: Modifications to the .gitignore file related to asset management, specifically concerning image files.
#69: Enhancements related to asset handling and feature parity between WASM and native Node modules, aligning with the focus on managing assets, particularly image files.

🐰 In the garden where images bloom,
PNGs now tracked, no more gloom.
With textures and jobs, we hop along,
Rendering dreams, where we belong.
Emscripten's path, so bright and clear,
In the code we dance, with joy and cheer! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

sonarcloud[bot] commented 3 weeks ago

Quality Gate failed

Failed conditions
23.9% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

xframes-project / xframes