Closed andreamancuso closed 1 week ago
[!CAUTION]
Review failed
The pull request is closed.
The changes in this pull request primarily involve updates to the ImGuiRenderer
class and associated files within the dear-imgui
package. Key modifications include replacing the <format>
header with <fmt/core.h>
, updating method implementations to utilize the fmt
library for string formatting, and adjusting OpenGL context settings. Additionally, the package.json
and vcpkg.json
files reflect version updates and new dependencies, while documentation is enhanced for Raspberry Pi OS. The .gitignore
file is also updated to exclude fmt.dll
.
File Path | Change Summary |
---|---|
packages/dear-imgui/cpp/app/include/imgui_renderer.h |
Updated header inclusion from <format> to <fmt/core.h> . |
packages/dear-imgui/cpp/app/src/imgui_renderer.cpp |
Replaced std::format with fmt::format , modified OpenGL context initialization, and added error callback for WebGPU. Updated method signatures for LoadTexture . |
packages/dear-imgui/examples/node-example/package.json |
Updated @xframes/node dependency version from 0.0.18 to 0.0.19 . |
packages/dear-imgui/npm/node/.gitignore |
Added entry for fmt.dll to be ignored by Git. |
packages/dear-imgui/npm/node/CMakeLists.txt |
Added ARM architecture support and included fmt library as a required dependency. |
packages/dear-imgui/npm/node/README.md |
Added instructions for Raspberry Pi OS and ensured proper formatting for Fedora 41 dependencies. |
packages/dear-imgui/npm/node/src/index.tsx |
Commented out "roboto-bold" and "roboto-mono-regular" font definitions in fontDefs . |
packages/dear-imgui/npm/node/vcpkg.json |
Added fmt library as a new dependency. |
imgui_renderer.h
file, specifically the inclusion of the <fmt/core.h>
header, indicating a shift in the formatting library used.🐰 In the code we play,
A new format leads the way,
Withfmt
we now align,
Rendering paths so fine,
For Raspberry Pi, we cheer,
As dependencies draw near! 🐇✨
[!WARNING]
Rate limit exceeded
@andreamancuso has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 46 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.📥 Commits
Reviewing files that changed from the base of the PR and between 6d120a372e9361e77ca4ffb1bdbd6a96610c2e25 and 8ecb35e48bf0bc4a09ce68e5f222cbdb92e3b553.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Summary by CodeRabbit
Release Notes
New Features
fmt
library for improved string formatting.Bug Fixes
Documentation
Chores
@xframes/node
to0.0.19
.fmt.dll
to.gitignore
.Style