xframium / xframium-java

xFramium - Rapid unified test case development
http://www.xframium.org
GNU General Public License v3.0
12 stars 18 forks source link

Global Implicit waits will be overridden when using DEVICE> CLEAN (BrowserCacheLogic) #53

Closed shivajibr closed 7 years ago

shivajibr commented 7 years ago

On using Clean option in DEVICE keyword, the Implicit wait setting is overridden,

We have this setting in driverConfig

Config for implicit waits

driver.propertyAdapters=org.xframium.device.property.SeleniumPropertyAdapter selenium.timeouts.implicitWait=60000

On using DEVICE>CLEAN, this value is reset to 0

finally { switchToContext(driver, currentContext); driver.manage().timeouts().implicitlyWait(0, TimeUnit.SECONDS); }

This is for both clearSafariIOSCache and clearChromeAndroidCache

These driver.manage.timeout statements should be removed from these methods and instead have a global setting in driverconfig

xframium commented 7 years ago

Resolved