xgcm / aerobulk-python

A python wrapper for aerobulk (https://github.com/brodeau/aerobulk)
GNU General Public License v3.0
14 stars 4 forks source link

Provisional fix for wind stress limit error #50

Closed jbusecke closed 1 year ago

jbusecke commented 1 year ago

Currently aerobulk has limit of 5N/m^2 hardcoded. As discussed here we can probably update that value to at least 10N/m^2.

I have submitted a PR upstream to increase the limit.

This PR is swapping the submodule pointer from the upstream main repo to my personal PR branch (this SO post was very helpful) to implement this fix in our code base ASAP. As soon as this is fixed upstream, we should repoint to the official aerobulk repo.

codecov[bot] commented 1 year ago

Codecov Report

Base: 90.03% // Head: 90.03% // No change to project coverage :thumbsup:

Coverage data is based on head (d1ea501) compared to base (3fd7316). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ======================================= Coverage 90.03% 90.03% ======================================= Files 7 7 Lines 251 251 ======================================= Hits 226 226 Misses 25 25 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `90.03% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgcm#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgcm). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgcm)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.