Add support for python 3.11

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (31fa4c7) 90.03% compared to head (f936f1c) 90.03%. Report is 5 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #68 +/- ## ======================================= Coverage 90.03% 90.03% ======================================= Files 7 7 Lines 251 251 ======================================= Hits 226 226 Misses 25 25 ``` | [Flag](https://app.codecov.io/gh/xgcm/aerobulk-python/pull/68/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgcm) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xgcm/aerobulk-python/pull/68/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgcm) | `90.03% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgcm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jbusecke commented 8 months ago

Lets see if 3.12 works as well?

jbusecke commented 4 months ago

3.12 does not seem to work (just stupidly created a dupe #74 and fails with

Obtaining file:///home/runner/work/aerobulk-python/aerobulk-python
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [7 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/home/runner/work/aerobulk-python/aerobulk-python/setup.py", line 7, in <module>
          import numpy.distutils.command.sdist  # noqa
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      ModuleNotFoundError: No module named 'numpy.distutils'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

On first glance this seems like something in numpy has changed in recent versions? This def needs some deeper investigation.

jbusecke commented 4 months ago

I added "<3.12" to python_requires to pin python during install for now. We will have to address 3.12 separately in #75

xgcm / aerobulk-python

Add support for python 3.11 #68

Codecov Report