search

xgcm / xcape

Fast convective parameters for numpy, dask, and xarray
Other
30 stars 11 forks source link

WIP: Dask dispatch #10

Closed chiaral closed 5 years ago

chiaral commented 5 years ago

I think I am trying to add my work to your branch here...

the tests pass - I think I have modified the signature for when it is a pressure level case. I started putting some if loops to check that arguments given as an input make sense, but I didn't put any break in it yet. I am not sure how to work that in. I will make a comment.

codecov-io commented 5 years ago

Codecov Report

Merging #10 into master will decrease coverage by 6.31%. The diff coverage is 67.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage    63.5%   57.19%   -6.32%     
==========================================
  Files           7        7              
  Lines         211      264      +53     
  Branches       55       73      +18     
==========================================
+ Hits          134      151      +17     
- Misses         65       91      +26     
- Partials       12       22      +10
Impacted Files Coverage Δ
xcape/core.py 73.42% <67.18%> (-13.25%) :arrow_down:
xcape/srh.py 46.66% <0%> (-46.67%) :arrow_down:
xcape/stdheight.py 53.84% <0%> (-23.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae2e6df...891d0ed. Read the comment docs.