search

xgcm / xcape

Fast convective parameters for numpy, dask, and xarray
Other
30 stars 11 forks source link

Adding CAPE code #2

Closed chiaral closed 5 years ago

chiaral commented 5 years ago

I did switched from one branch to the other, but it is showing my second change - regarding the reshape function here as well.

Also there are some notebooks that I use to test the code I can delete those.

rabernat commented 5 years ago

This is a great start! πŸ˜„

Please remove the notebooks and notebook checkpoints from the branch. (You can remove a file from tracking without deleting it locally; see https://stackoverflow.com/questions/1143796/remove-a-file-from-a-git-repository-without-deleting-it-from-the-local-filesyste).

Please also remove the commented out code.

To update your PR, make another commit and run git push origin ADDCAPECODE again.

rabernat commented 5 years ago

Also, it is really ideal to accompany any new code with corresponding tests. πŸ˜‰

rabernat commented 5 years ago

So in #3 I added some fixed that make the test run automatically on every PR.

It would be great if you could rebase.

git remote add upstream https://github.com/xgcm/xcape.git
git fetch upstream
git rebase upstream/master
git push origin ADDCAPECODE
codecov-io commented 5 years ago

Codecov Report

Merging #2 into master will increase coverage by 3.3%. The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #2     +/-   ##
=========================================
+ Coverage   46.09%   49.39%   +3.3%     
=========================================
  Files           5        5             
  Lines         128      166     +38     
  Branches       39       48      +9     
=========================================
+ Hits           59       82     +23     
- Misses         63       76     +13     
- Partials        6        8      +2
Impacted Files Coverage Ξ”
xcape/cape_fortran.py 11.11% <11.11%> (-38.89%) :arrow_down:
xcape/core.py 78.08% <83.72%> (-2.88%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 2c26fee...4a1cd1b. Read the comment docs.

rabernat commented 5 years ago

Yay!

I'll merge for now, then we can clean things up in a future PRs.