jrbourbeau commented 3 years ago

This is one way to enable CI to start passing again in light of https://github.com/xgcm/xhistogram/issues/27. Another option would have been to explicitly xfail test_histogram_shape when using dask=2021.3.0. The approach here seems a little simpler to me, but I'm happy to update to something else if others prefer.

codecov[bot] commented 3 years ago

Codecov Report

Merging #34 (965960a) into master (9992eba) will increase coverage by 0.17%. The diff coverage is 97.14%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   94.24%   94.41%   +0.17%     
==========================================
  Files           3        3              
  Lines         226      215      -11     
  Branches       65       58       -7     
==========================================
- Hits          213      203      -10     
  Misses          8        8              
+ Partials        5        4       -1

Impacted Files	Coverage Δ
xhistogram/core.py	`98.49% <93.33%> (ø)`
xhistogram/duck_array_ops.py	`78.26% <100.00%> (-2.39%)`	:arrow_down:
xhistogram/xarray.py	`91.52% <100.00%> (-0.42%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2ff727...965960a. Read the comment docs.

rabernat commented 3 years ago

This is great @jrbourbeau. Thanks so much for all your help around here!

jrbourbeau commented 3 years ago

Yeah, no problem. Happy to help out where I can

xgcm / xhistogram

Temporarily use Dask version constraint in CI #34

Codecov Report