search

xgcm / xhistogram

Fast, flexible, label-aware histograms for numpy and xarray
https://xhistogram.readthedocs.io
MIT License
90 stars 20 forks source link

Noted how to deal w NaNs in weights parameter #47

Closed shanicetbailey closed 3 years ago

shanicetbailey commented 3 years ago

sorry for so many commits, still a novice git user.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 3 years ago

Codecov Report

Merging #47 (d1a7930) into master (2681aee) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files           3        3           
  Lines         215      215           
  Branches       58       58           
=======================================
  Hits          203      203           
  Misses          8        8           
  Partials        4        4
Impacted Files Coverage Δ
xhistogram/xarray.py 91.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2681aee...d1a7930. Read the comment docs.

rabernat commented 3 years ago

Thanks for this very helpful contribution @stb2145!