search

xgcm / xhistogram

Fast, flexible, label-aware histograms for numpy and xarray
https://xhistogram.readthedocs.io
MIT License
89 stars 19 forks source link

Pass weights to histogram_bin_edges #65

Closed dougiesquire closed 3 years ago

dougiesquire commented 3 years ago

To simplify the implementation of #49 we stopped passing weights on to numpy's histogram_bin_edges. While it's true that weights is not used by this function at the moment, it may be used in the future. Following #61, it's now trivial to pass weights on.

I'm not sure what a test for this would look like since weights doesn't actually do anything here.

codecov[bot] commented 3 years ago

Codecov Report

Merging #65 (f1cd62b) into master (38becf6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files           2        2           
  Lines         245      245           
  Branches       72       72           
=======================================
  Hits          235      235           
  Misses          7        7           
  Partials        3        3
Impacted Files Coverage Δ
xhistogram/core.py 97.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38becf6...f1cd62b. Read the comment docs.