xgcm / xhistogram

Fast, flexible, label-aware histograms for numpy and xarray
https://xhistogram.readthedocs.io
MIT License
90 stars 20 forks source link

Release v0.3.0: update release history #66

Closed dougiesquire closed 3 years ago

dougiesquire commented 3 years ago

A quick update to the release history prior to release

codecov[bot] commented 3 years ago

Codecov Report

Merging #66 (557ef78) into master (5c12e17) will increase coverage by 1.20%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   95.98%   97.18%   +1.20%     
==========================================
  Files           2        2              
  Lines         249      249              
  Branches       71       71              
==========================================
+ Hits          239      242       +3     
+ Misses          7        5       -2     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
xhistogram/xarray.py 96.42% <0.00%> (+5.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c12e17...557ef78. Read the comment docs.

dougiesquire commented 3 years ago

@TomNicholas, when the tests ran here we got an error in:

xhistogram/test/test_chunking_hypotheses.py::TestChunkingHypotheses::test_all_chunking_patterns_dd_hist

Would you mind taking a look when you get a chance?

TomNicholas commented 3 years ago

@dougiesquire I have no idea why that failed - I can't get it to reproduce locally. I used the same conda env (required because you can't use hypothesis.reproduce_failure with a different version of hypothesis), but this is on ubuntu, not mac. Instead I get

________________________________________________________________ TestChunkingHypotheses.test_all_chunking_patterns_dd_hist[1] ________________________________________________________________

self = <xhistogram.test.test_chunking_hypotheses.TestChunkingHypotheses object at 0x7fe6f8392040>, n_vars = 1

>   ???
E   hypothesis.errors.DidNotReproduce: Expected the test to raise an error, but it completed successfully.

xhistogram/test/test_chunking_hypotheses.py:70: DidNotReproduce

However, I just tried forcing the CI to re-run all jobs and this time it passed ?!? I say we just forget about it.