xgcm / xhistogram

Fast, flexible, label-aware histograms for numpy and xarray
https://xhistogram.readthedocs.io
MIT License
89 stars 19 forks source link

try dask.array #71

Closed aaronspring closed 2 years ago

aaronspring commented 2 years ago
codecov[bot] commented 2 years ago

Codecov Report

Merging #71 (75f9184) into master (e01291b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files           2        2           
  Lines         249      249           
  Branches       71       71           
=======================================
  Hits          242      242           
  Misses          5        5           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e01291b...75f9184. Read the comment docs.

aaronspring commented 2 years ago

thanks @jrbourbeau for the quick description

ok. so there is no way around install_requires and the other extras (bokeh in diagnostics) were not even installed before.

so this PR here would only ensure that a matching numpy version is used @rabernat but xarray already kind of does that by itself. should this PR still go forward?

aaronspring commented 2 years ago

thanks for the explanation. the originating issue was https://github.com/xarray-contrib/xskillscore/issues/359, then we discovered that xhistogram relies on dask.

also xhistogram on conda-forge relies on dask https://github.com/conda-forge/xhistogram-feedstock/blob/master/recipe/meta.yaml - not sure whether there also specifying dask.array works, but you said dask[array] is a pip thing, so likely not, but we could use dask-core on the next release maybe

rabernat commented 2 years ago

If we are happy about this I will merge. :+1: if you think we are done here.

aaronspring commented 2 years ago

happy to merge and maybe we can ship the conda version with dask-core, see https://github.com/conda-forge/xhistogram-feedstock/pull/9