Closed aaronspring closed 2 years ago
Merging #71 (75f9184) into master (e01291b) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 97.18% 97.18%
=======================================
Files 2 2
Lines 249 249
Branches 71 71
=======================================
Hits 242 242
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e01291b...75f9184. Read the comment docs.
thanks @jrbourbeau for the quick description
ok. so there is no way around install_requires
and the other extras (bokeh
in diagnostics) were not even installed before.
so this PR here would only ensure that a matching numpy
version is used @rabernat but xarray
already kind of does that by itself. should this PR still go forward?
thanks for the explanation. the originating issue was https://github.com/xarray-contrib/xskillscore/issues/359, then we discovered that xhistogram
relies on dask
.
also xhistogram
on conda-forge
relies on dask
https://github.com/conda-forge/xhistogram-feedstock/blob/master/recipe/meta.yaml - not sure whether there also specifying dask.array
works, but you said dask[array]
is a pip
thing, so likely not, but we could use dask-core
on the next release maybe
If we are happy about this I will merge. :+1: if you think we are done here.
happy to merge and maybe we can ship the conda
version with dask-core
, see https://github.com/conda-forge/xhistogram-feedstock/pull/9