search

xgeekshq / js-intl-kitchen-sink

A kitchen sink for the ECMAScript Internationalization API (Intl)
https://js-intl-kitchen-sink.netlify.com/
MIT License
9 stars 27 forks source link

The suggested UI changes at DateTimeFormat page #95

Closed fllprbt closed 5 years ago

fllprbt commented 5 years ago

https://github.com/xgeekshq/js-intl-kitchen-sink/issues/89

crop2

@luisFilipePT

fllprbt commented 5 years ago

The colons were removed from the <Form.Item /> because they do not appear on the same line with my "<PopoverContent />".

Some info regarding this issue: When antd's <Form.Item /> is given a label prop (can be a custom component), it wraps it with an html label element. The colons are rendered as ::after of this label.

I have no control on the styling of the label that antd creates. Everything could be resolved if I could change it to flex.

update: I will try passing a className like .formItem > label and see how it goes today, then update.

fllprbt commented 5 years ago

conflicts

Oh, did not know antd comes packed with its icons. Ye, I will update tonight. Cheers!

fllprbt commented 5 years ago

Updated MR crop3.

Could you also tell me why the MR has not a clean diff :O ? I merged upstream.