xgfe / react-native-datepicker

react native datePicker component for both Android and IOS, useing DatePikcerAndroid, TimePickerAndroid and DatePickerIOS
MIT License
2.12k stars 726 forks source link

Not Compatible with AndroidX #345

Closed eftikharEmad closed 5 years ago

eftikharEmad commented 5 years ago

Issue

Hello it seems react-native-date-picker is not compatible with androidx, is there any hope to be updated?

zbrukas commented 5 years ago

@eftikharEmad was it updated?

zeabdelkhalek commented 4 years ago

same issue

eftikharEmad commented 4 years ago

we used this https://github.com/henninghall/react-native-date-picker "react-native-date-picker": "^2.4.2", all was good

Darex1991 commented 1 year ago

Hi, regards this problem my Android studio migrated that, and here is a patch for that. Could anyone confirm if is it ok?

I'm using 4.1.1:


diff --git a/node_modules/react-native-date-picker/android/build.gradle b/node_modules/react-native-date-picker/android/build.gradle
index f1cc0a2..f2c3304 100644
--- a/node_modules/react-native-date-picker/android/build.gradle
+++ b/node_modules/react-native-date-picker/android/build.gradle
@@ -12,7 +12,7 @@ android {
         minSdkVersion safeExtGet('minSdkVersion', 18)
         targetSdkVersion safeExtGet('targetSdkVersion', 25)

-        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
+        testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
     }
     buildTypes {
         release {