search

xgh69 / PvpToggle

Private settings for PvP for Bukkit/Spigot minecraft servers! WorldGuard flags are supported.
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

add config reload #4

Closed seema84 closed 8 years ago

seema84 commented 8 years ago

add config reload

xgh69 commented 8 years ago

Config is reloading, because plugin is restarting - config is reloading in onEnable() in PvpToggle plugin.

seema84 commented 8 years ago

ok i'm confused about this info "Command /pvpadmin reload restart PvpToggle plugin, not configuration." but its ok when it is in onEnable()

MarcinWieczorek commented 8 years ago

@xgh69 reloads the whole plugin by Spigot's PluginManager, config loads itself when the plugin gets enabled again. Don't worry about all this @seema84. Code you commited is just an unnecessary action that has no point.

seema84 commented 8 years ago

yes its right if you restart the whole plugin on reload - my code was a single config reload (without plugin reload)

MarcinWieczorek commented 8 years ago

Well, I don't know why reloading whole plugin is better than reloading the config. Ask the author. Even though your code was a single config reload as you said, next lines still reload the whole thing.