Fixing things in drawing functions

[maximelucas]

• addressed #433 @thomasrobiglio can you check?
• fixed #443 (one function was missing)
• I tried to make draw_dihypergraph() more consistent with the other (updated) functions. I solved some bugs on the way, but making it fully consistent (and bug free) will require a bigger rewrite. I'll open an issue.
• Added some tests for draw_dihypergraph(). More needed.

[codecov[bot]]

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (536f592) 92.03% compared to head (ac95a64) 92.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #476 +/- ## ========================================== - Coverage 92.03% 92.00% -0.03% ========================================== Files 60 60 Lines 4392 4429 +37 ========================================== + Hits 4042 4075 +33 - Misses 350 354 +4 ``` | [Files](https://app.codecov.io/gh/xgi-org/xgi/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgi-org) | Coverage Δ | | |---|---|---| | [xgi/drawing/layout.py](https://app.codecov.io/gh/xgi-org/xgi/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgi-org#diff-eGdpL2RyYXdpbmcvbGF5b3V0LnB5) | `99.18% <100.00%> (-0.02%)` | :arrow_down: | | [xgi/drawing/draw\_utils.py](https://app.codecov.io/gh/xgi-org/xgi/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgi-org#diff-eGdpL2RyYXdpbmcvZHJhd191dGlscy5weQ==) | `88.42% <50.00%> (-0.19%)` | :arrow_down: | | [xgi/stats/\_\_init\_\_.py](https://app.codecov.io/gh/xgi-org/xgi/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgi-org#diff-eGdpL3N0YXRzL19faW5pdF9fLnB5) | `85.46% <50.00%> (-0.42%)` | :arrow_down: | | [xgi/drawing/draw.py](https://app.codecov.io/gh/xgi-org/xgi/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xgi-org#diff-eGdpL2RyYXdpbmcvZHJhdy5weQ==) | `77.94% <81.18%> (+1.62%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[thomasrobiglio]

thanks max! I'll check about #433

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[maximelucas]

This is ready for review.

With the last commits, I rewrote draw_dihypergraph. The new implementation:

• uses draw_nodes() to draw both types of nodes
• uses individual FancyArrowPatch for the edges. This mimicks Networkx for directed graphs. I commented in the code why this seems to be the best solution (see this discussion). Arrows can be parametrised with arrowstyle, arrowsize, connectionstyle.
• solves bugs when setting colors/linewidths/etc.
• is now consistent with the other new functions, and drops dependency of _color_arg_to_dict and _scalar_arg_to_dict.
• has more tests

• has a new argument iterations to control the layout (related to #396). The previous layout was a spring layout computed on the "augmented projection", so that "edge"-nodes were sometimes on the outside, not at the barycenters. Now, the layout is computed as follows:

  1. compute a spring layout based solely on the original nodes.
  2. add the "edge"-nodes at the barycenters (at this point, nodes may overlap in larger networks)
  3. starting from this initial layout, run a spring layout on the whole thing, using iterations iterations. So 0 iterations will yield the layout computed in ii, while many iterations will yield the layout that we used to have.

  There is also a new pos argument so that user can play around. We could provide a special layout function for this in the future if we find a good way to do it.

• has a new In Depth tutorial

[maximelucas]

Good points Thomas, thanks! All addressed now I think.

[nwlandry]

Great work, @maximelucas!! Much needed changes and thanks for pushing this through!