xgi-org / xgi

CompleX Group Interactions (XGI) is a Python package for higher-order networks.
https://xgi.readthedocs.io
Other
172 stars 27 forks source link

make drawing dihypergraph and multilayer consistent with other drawing functions #477

Closed maximelucas closed 8 months ago

maximelucas commented 9 months ago

draw_dihypergraph and draw_multilayer have not been updated since we updated the drawing of nodes #441 and hyperedges #456 . We should update them for consistency by using collections. We should also remove their dependencies on the "old" functions _scalar_arg_to_dict() and _color_arg_to_dict that have problems #442 #410, to use the newer _parse_color_arg , _draw_arg_to_arr, _interp_draw_arg. This is the last place the "old" ones are used.

For draw_dihypergraph, we could try to use more existing functions. The drawing of the "edge nodes" could be done via the draw_nodes function.

maximelucas commented 8 months ago

Fixed by #476 for draw_dihypergraph. draw_multilayer remains.