Closed maximelucas closed 11 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
de8a39c
) 91.89% compared to head (1150648
) 92.04%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Good ideas Thomas! Should be all good now.
For 3) I added a note in the docstrings. At first I thought we could just do the following to change it automatically like you said
if node_labels and node_size is None:
node_size = 15
but by default node_size = 7
not None
in the function call. So if we want to do it like this in another PR we would maybe need to set it to None
and do inside of the function if node_size is None: node_size = 7
...
draw_hypergraph_hull
was last function to make consistent #477. I noticed the edge-plotting part was doing exactly the same asdraw_hyperedges
except for the few lines drawing the hulls. So I:hull=False
andradius
argument todraw_hyperedges
, which needed just 10 more lines of code to work. So everything works out of the box becausedraw_hyperedges
works.draw
so we can now doxgi.draw(H, hull=True)
.draw_hypergraph_hull
and_draw_hull
as they are not used anymore._color_arg_to_dict
as not used anymoreThis closes #477 and #388. Related to #404.