xgi-org / xgi

CompleX Group Interactions (XGI) is a Python package for higher-order networks.
https://xgi.readthedocs.io
Other
171 stars 27 forks source link

Updated the return type of Katz centrality #530

Closed nwlandry closed 3 months ago

nwlandry commented 3 months ago

This PR accomplishes the following:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.12%. Comparing base (369a10a) to head (eb3258b).

Files Patch % Lines
xgi/stats/nodestats.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #530 +/- ## ========================================== - Coverage 92.19% 92.12% -0.07% ========================================== Files 60 60 Lines 4392 4393 +1 ========================================== - Hits 4049 4047 -2 - Misses 343 346 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nwlandry commented 3 months ago

Looks good! We should mention that the values that are returned are normalised, can you add that?

I have mentioned that centralities are 1-normalized in the Returns field.

nwlandry commented 3 months ago

Thanks for the review!!