search

xgi-org / xgi

CompleX Group Interactions (XGI) is a Python package for higher-order networks.
https://xgi.readthedocs.io
Other
180 stars 28 forks source link

Possible error in stats #552

Closed nwlandry closed 2 months ago

nwlandry commented 3 months ago

In this line in the constructor of IDStat, there is this line:

self.kwargs = {} if args is None else kwargs

Shouldn't it be kwargs?

leotrs commented 3 months ago

It seems like you're right. Did you discover this by some weird or unexpected behavior? If so can you provide an example where this object doesn't behave as expected?

On Sun, Jun 9, 2024, 5:15 AM Nicholas Landry @.***> wrote:

In this line in the constructor of IDStat, there is this line:

self.kwargs = {} if args is None else kwargs

Shouldn't it be kwargs?

— Reply to this email directly, view it on GitHub https://github.com/xgi-org/xgi/issues/552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAILYACRI5YOUOBKFWCZDMDZGPCDRAVCNFSM6AAAAABJAQEEOSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DCOJZGQ3DSMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

nwlandry commented 2 months ago

Hi @leotrs --- I tried my best to create an issue, but I can't create an example which will raise undesired behavior. Nonetheless, I think my PR makes the code more explainable.