xgi / houdoku-extensions

18 stars 6 forks source link

Entry in library shows there are (new) chapters when there are none (MangaDex) #53

Closed ScruffiX closed 2 years ago

ScruffiX commented 2 years ago

Acknowledgements

Houdoku version

v2.9.2

Affected extension(s)

MangaDex

Steps to reproduce

Add Series from MangaDex to Library

Expected behavior

Available Chapters shown represent available chapters to read.

Actual behavior

When adding some series from MangaDex some series are marked as having chapters / new chapters. But when entering the entry there are no said chapters.

Example entry: Hyper Luck image

All chapters available in the Manhwa have been marked as read, yet it still shows there are more chapters to read image

The unread 9 chapters do not exist on MangaDex itself.

Some Other examples: image image

image When re-adding this series it says that there are 5 chapters available. Marking the 4 available ones as read brings the following result. image

image image

Additional information

It only seems to affect some chosen shows and doesn't feel random i guess. I only experienced this issue with MangaDex entries. This is an annoying issue because you always see unread shows pop up when there are no new chapters (I sort by Unread ascending).

I am guessing that Houdoku gets the chapter status from somewhere else then the Extension itself for this Error to happen?

xgi commented 2 years ago

The issue was the displayed number included chapters from languages that aren't displayed (there's a setting for this, Settings->General->Chapter Languages). For Hyper Luck for example, there are Portuguese chapters going to 29, so even when English chapters up to 20 were read, it still thinks there are 9 remaining.

With https://github.com/xgi/houdoku/commit/5d74231d651caa5cba1b1fadb87cb4b1207dc47c the count will now only include chapters that match the language setting. Thanks!