search

xgi / houdoku

Manga reader and library manager for the desktop
https://houdoku.org
MIT License
744 stars 39 forks source link

Resolve issue #224 - Click anywhere on chapter list entry to read #317

Closed wintrmut3 closed 9 months ago

wintrmut3 commented 10 months ago

This PR resolves issue #224 by removing the "Read" button and replacing the with a useNavigate hook bound to click on the entire table row. For visual feedback, the text is underlined using the tag when anywhere on the row is hovered.

Originally: image

After the change, the Read button is removed and its functionality added to the whole ChapterTableRow:

No Hover: image

On Hover (Note: Chapter title is underlined): image

xgi commented 9 months ago

Thank you! I ended up making 2 followup changes:

  • I didn't really like the underline, and some series/extensions don't display titles at all, which wouldn't give any indication when hovering. I changed this to just use highlightOnHover instead
  • There was an issue where clicking the download button or "read status" checkbox would open the reader. I updated those button handlers to have event.stopPropagation()

(I would've asked you to make those changes, but I didn't want to ask after not getting around to this in 2 weeks. Thanks for the PR!)