xgi / houdoku

Manga reader and library manager for the desktop
https://houdoku.org
MIT License
744 stars 39 forks source link

Select language of the chapter while reading #324

Closed rootBrz closed 7 months ago

rootBrz commented 8 months ago

Implemented selection of translation of the chapter while reading it. Shows only languages chosen in settings, if none selected shows all. Added "Vol." because some sites has wrong volume set for chapter, or none set at all.

image

rootBrz commented 8 months ago

In the new commits, I've made all translations of the chapter marked as read at the end of the chapter, so that the Continue button opens the next chapter instead of another translation.

I've also made the menu less cluttered by only showing the preferred language per chapter, since you can now select it in Reader. If the language is missing, a second preferred language is displayed, and so on. If no preferred language is selected, all languages are displayed.

image image

xgi commented 7 months ago

Thanks, I really like this! I think being able to switch between different versions of the same chapter is very useful. I'll merge this, but there are a few parts I'm going to change:

Sorry it took me so long to get to this. Thanks!

rootBrz commented 7 months ago
* I don't agree with only showing one language per chapter in the table. Mainly because I don't view the "chapter languages" input as an ordered list. I'd prefer for users to know what languages a chapter is available in from the table.

Maybe then add this as optional setting? Something like "Show only the main language from "Chapter Languages"" or same language selector as in reader mode, but somewhere in the table. With default behavior the table is really cluttered, and if you're bilingual just like me, you mainly want to read something in one language and switch to another language in the middle of reading if you don't understand something (this is also the reason why page number should be kept, though sometimes it doesn't match).

Thank you for the awesome program!

xgi commented 7 months ago

Maybe then add this as optional setting? Something like "Show only the main language from "Chapter Languages"" or same language selector as in reader mode, but somewhere in the table. With default behavior the table is really cluttered, and if you're bilingual just like me, you mainly want to read something in one language and switch to another language in the middle of reading if you don't understand something (this is also the reason why page number should be kept, though sometimes it doesn't match).

Thank you for the awesome program!

That's fair, I'll add it as a setting (disabled by default though). My main concern was that I don't want users to think that a chapter isn't available in a language just because they don't see it in the list. There will probably be people who don't even notice the language dropdown in the reader.

I think ultimately this can be communicated better in the chapter table. Having one row per chapter number is a good idea, but we can maybe either have the language dropdown in the row (as you mentioned) or have rows be expandable to show different available versions. But we can save that for later :)

Thanks!