xgouchet / Stanley

An Android app explorer for developers (extract the manifest and other info from any installed application)
Other
94 stars 32 forks source link

Display intent filters of activities, services and broadcast receivers #52

Closed ekrmh closed 3 years ago

ekrmh commented 3 years ago

Fix #51 #34

Solution

According my research we can not obtain intent filters from package manager. Hence currently parsing AndroidManifest.xml file is a only solution to obtain intent-filters. Google Issue Tracker - Support PackageManager.GET_INTENT_FILTERS

This PR parses the AndroidManifest.xml file, obtain intent-filters of activities, services and broadcast receivers and display them in the app detail page.

Screenshot_20201012_134606_fr xgouchet packageexplorer debug

Update ( https://github.com/xgouchet/Stanley/pull/52/commits/14bd36e3b8afeec691d85638cb7da9d741fd8cdc )

Screenshot_20201014_021817_fr xgouchet packageexplorer debug

Update ( https://github.com/xgouchet/Stanley/pull/52/commits/30a3294c90b6f74ae8b9039b68bb24a650f02a4c )

Screenshot_20201015_180652_fr xgouchet packageexplorer debug

Update ( https://github.com/xgouchet/Stanley/pull/52/commits/7a7a2d2370709062e165af18433ce79f48eb74c0 )

Screenshot_20201015_191437_fr xgouchet packageexplorer debug

xgouchet commented 3 years ago

Overall nice work, thanks @ekrmh My main concern with this implementation is that the whole information is combined in a single text view, meaning that we loose clarity, and the automatic copy to clipboard on tap copies the whole thing, which makes it useless. I'm ok with your approach of displaying the data itself, but maybe you can add one item per intent filter. Another approach would be to add an action with a ➕ icon on activities, services etc… and open a new screen to get the details about the intent filters and meta data for that specific component.

ekrmh commented 3 years ago

@xgouchet Thanks for the comment. I understood your concern. In my opinion, displaying intent filters one by one will be better approach than displaying them in a new screen. I will update PR and show the intent filters one by one on the detail screen if appropriate for you and they will be copyable.

ekrmh commented 3 years ago

@xgouchet Thanks, I would like to contribute more.