search

xgouchet / Stanley

An Android app explorer for developers (extract the manifest and other info from any installed application)
Other
94 stars 32 forks source link

updated static margin, padding and texsize in layout amd updated dime… #78

Closed vidyajejurkar closed 10 months ago

vidyajejurkar commented 10 months ago

…n.xml

xgouchet commented 10 months ago

Hi @vidyajejurkar , and thanks a lot for your contribution 😊

I do like the idea of using named dimensions in the various XML layouts in the app, I'm thinking it'd make more sense to define independant dimensions based on their semantic meaning rather than their value. Having a dimension named _24dp, means that if I want to change the design, I'll either have to change the name to the new value, or have a name that don't reflect it's value anymore.

vidyajejurkar commented 10 months ago

Hi @xgouchet I have given name _24dp as I found 24dp used as margin as well as padding. So we can reuse same _24dp for both margin as well as padding. Same applicable for 0dp, 4dp , 8dp