search

xguerin / bitstring

OCaml Bitstring - bitstring matching for OCaml
GNU General Public License v2.0
67 stars 8 forks source link

Add support for FreeBSD #23

Closed kit-ty-kate closed 3 years ago

kit-ty-kate commented 3 years ago

The CI on opam-repository failed to build bitstring on FreeBSD. Here is a PR to fix the issue. This might change in FreeBSD 13.0 though but this should be fine anyway. See: https://reviews.freebsd.org/D19500

This PR also adds testing for macos, freebsd and arm64 just in case.

xguerin commented 3 years ago

Thanks 👍 I’ll merge and retag once the tests are done.

kit-ty-kate commented 3 years ago

I also added a last commit to fix the syntax of the opam file as with-test = "false" is not correct.

xguerin commented 3 years ago

I also added a last commit to fix the syntax of the opam file as with-test = "false" is not correct.

~Thanks, but I beg to differ. According to the grammar, it is correct; besides,opam lint does not throw any error.~

~Also, the original test checks that either ocaml >= 4.08 when tests are enabled or that ocaml >= 4.04 when they are not, which the proposed version does not.~

Argh ok, I believe I only tested empirically. Since dune does not support the negation yet, as long as that works, I’m fine with it.