Closed lbwexler closed 2 months ago
yes
On Tue, Jul 16, 2024 at 7:28 AM Anselm McClain @.***> wrote:
@.**** commented on this pull request.
In grails-app/domain/io/xh/hoist/role/provided/Role.groovy https://github.com/xh/hoist-core/pull/369#discussion_r1679228053:
@@ -33,6 +33,12 @@ class Role implements JSONFormat { lastUpdatedBy maxSize: 50 }
- // We don't expect a huge number of roles.
- // Tighten as example of a custom cache config being applied to a collection cache (Role.members)
- static cache = {
- evictionConfig.size = 1000
Looked again at this and realizing - is this static cache = {} closure on domain objects a new property that we support through the custom code below in ClusterConfig? I.e. not supported by Grails/GORM but a Hoist feature?
— Reply to this email directly, view it on GitHub https://github.com/xh/hoist-core/pull/369#discussion_r1679228053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARTL2PCTJDW2FT77RVBZ4LZMT7WNAVCNFSM6AAAAABKZUF2P2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZZHE3TAMBSHA . You are receiving this because you modified the open/close state.Message ID: @.***>
Should be a simplification and more straightforward use of the hazelcast config API. The get methods already do clone the current configuration and "add" a new configuration. I think we may have been thrown off with a very specific bug around the failure to deep clone evictionConfig