Admin cluster tab refresh

[ghsolomon]

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be checked off to indicate they have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.

• [x] Caught up with develop branch as of last change.
• [x] Added CHANGELOG entry, or determined not required.
• [x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
• [x] Updated doc comments / prop-types, or determined not required.
• [x] Reviewed and tested on Mobile, or determined not required.
• [x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to collapse multiple intermediate commits into a single commit representing the overall feature change. This helps keep the commit log clean and easy to scan across releases. PRs containing a single commit should be rebased when possible.

[ghsolomon]

New errorMessageBanner (local to the clusterTab component for now):

[ghsolomon]

@lbwexler switched to using errorMessage cmp:

[amcclain]

I'm going to let you guys decide which way you want to go on the error handling - but I can really picture myself trying to work with the admin client and looking at something specific in any of the cluster tabs to diagnose an issue and then 💥 everything just disappears.

I would rather go the other direction, with eg the log viewer not clearing itself so eagerly, but instead showing an indicator that you are looking at a view that couldn't be refreshed.

I suppose there are two ways to think about how to make a tool like this admin console reliable:

• Never show anything that might be out of date - if in doubt, clear and hide it all
• Always strive to show/maintain what you can - something is going wrong or flapping in / out, let an admin review / keep reviewing whatever we can keep showing

🤷

[amcclain]

(imagine it's the load balancer that's having the issue - every other request goes to a blackhole)

[lbwexler]

I think my proposal splits the difference -- it preserves maximal state, and just masks things temporarily.

We could eventually replace the mask with the banner, but I think my solution is less jarring

On Fri, Sep 13, 2024 at 10:36 AM Anselm McClain @.***> wrote:

I'm going to let you guys decide which way you want to go on the error handling - but I can really picture myself trying to work with the admin client and looking at something specific in any of the cluster tabs to diagnose an issue and then 💥 everything just disappears.

I would rather go the other direction, with eg the log viewer not clearing itself so eagerly, but instead showing an indicator that you are looking at a view that couldn't be refreshed.

I suppose there are two ways to think about how to make a tool like this admin console reliable:

• Never show anything that might be out of date - if in doubt, clear and hide it all
• Always strive to show/maintain what you can - something is going wrong or flapping in / out, let an admin review / keep reviewing whatever we can keep showing

🤷

— Reply to this email directly, view it on GitHub https://github.com/xh/hoist-react/pull/3783#issuecomment-2349113298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARTL2PB5WQBSGOZMU7MTGDZWLZ67AVCNFSM6AAAAABOBRCWY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZGEYTGMRZHA . You are receiving this because you were mentioned.Message ID: @.***>