xh / hoist-react

🏗️ ⚛️ The XH Hoist toolkit for React
https://xh.io
Apache License 2.0
24 stars 9 forks source link

Improve Exception/Connectivity handling with Cluster Tab #3785

Closed lbwexler closed 3 weeks ago

lbwexler commented 3 weeks ago

Cluster Tab

General

See related Hoist-Core PR

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be checked off to indicate they have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.

If your change is still a WIP, please use the "Create draft pull request" option in the split button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to collapse multiple intermediate commits into a single commit representing the overall feature change. This helps keep the commit log clean and easy to scan across releases. PRs containing a single commit should be rebased when possible.

lbwexler commented 3 weeks ago

@amcclain -- was trying to get Greg's buy-in here, before asking for your review, but think this change represents my best thinking on this.

ghsolomon commented 3 weeks ago

Just reviewed. This looks great to me - really nice use of LoadSupport.lastLoadException, which I'll have to start using!

lbwexler commented 3 weeks ago

Reviewed with ATM as well and will merge this shortly, as we all seem to like the overall approach

We discussed future iterations providing even more information in the mask about the state of the last load attempt. Useful for reassuring anxious XH developers.