Closed lbwexler closed 3 weeks ago
@amcclain -- was trying to get Greg's buy-in here, before asking for your review, but think this change represents my best thinking on this.
Just reviewed. This looks great to me - really nice use of LoadSupport.lastLoadException
, which I'll have to start using!
Reviewed with ATM as well and will merge this shortly, as we all seem to like the overall approach
We discussed future iterations providing even more information in the mask about the state of the last load attempt. Useful for reassuring anxious XH developers.
Cluster Tab
General
toast
to avoid extra clickSee related Hoist-Core PR
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be checked off to indicate they have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split button below to indicate it is not ready yet for a final review.