xh / hoist-react

🏗️ ⚛️ The XH Hoist toolkit for React
https://xh.io
Apache License 2.0
24 stars 9 forks source link

ColumnFilter Values Tab's storeFilterField could be given a more flexible match mode setting #3809

Closed cnrudd closed 1 month ago

cnrudd commented 1 month ago

The ColumnFilter dialog's Values Tab has a storeFilterField in its header who's matchMode setting is currently hard coded to "startWord". https://github.com/xh/hoist-react/blob/183aef1f66621974d280ad9162ad0f23caf241d8/cmp/store/StoreFilterField.ts#L57 https://github.com/xh/hoist-react/blob/183aef1f66621974d280ad9162ad0f23caf241d8/cmp/store/impl/StoreFilterFieldImplModel.ts#L145 https://github.com/xh/hoist-react/blob/183aef1f66621974d280ad9162ad0f23caf241d8/desktop/cmp/grid/impl/filter/values/ValuesTab.ts#L36

Excel's column filter dialog has a quickfilter field in its header toolbar and its matchMode is "any".

Users who are accustomed to working with Excel are questioning Hoist's choice of "startWord", and find "any" to be more useful, since it provides a larger, more inclusive result set.

If we have other good reasons to stick with "startWord", we might consider offering the ability to configure this setting at the grid or column level.

Most of Hoist's own uses of storeFilterField have chosen to go with 'any': https://github.com/search?q=repo%3Axh%2Fhoist-react%20matchMode&type=code