search

xh / hoist-react

🏗️ ⚛️ The XH Hoist toolkit for React
https://xh.io
Apache License 2.0
24 stars 9 forks source link

Fixed `genDisplayName` method to use reg-ex that works on iOS Safari … #3816

Closed cnrudd closed 1 month ago

cnrudd commented 1 month ago

…16 (used by BB Access)

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be checked off to indicate they have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.

If your change is still a WIP, please use the "Create draft pull request" option in the split button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to collapse multiple intermediate commits into a single commit representing the overall feature change. This helps keep the commit log clean and easy to scan across releases. PRs containing a single commit should be rebased when possible.

cnrudd commented 1 month ago

After more digging, I think that the regex that I changed is probably not the cause of the error on the clients device. There is probably an offending regex in some library code. We are going to ask the client to make sure he is on ios18 before digging further.

cnrudd commented 1 month ago

Source of issue was found in GFM support, brought in to framework in v65.0.0. The offending reg ex is in this lib: https://github.com/syntax-tree/mdast-util-gfm-autolink-literal See their issue: https://github.com/syntax-tree/mdast-util-gfm-autolink-literal/issues/10

Closing PR without merging - @amcclain already put the fontawesome fix into develop.