search

xh / hoist-react

🏗️ ⚛️ The XH Hoist toolkit for React
https://xh.io
Apache License 2.0
24 stars 9 forks source link

Add `agParams` to `ColumnEditorFn` #3834

Open ghsolomon opened 1 week ago

ghsolomon commented 1 week ago

agParams is a required property of EditorProps: https://github.com/xh/hoist-react/blob/2975272a12a559fcfdf710cc7f7d66b4095bd411/desktop/cmp/grid/editors/EditorProps.ts#L14-L28

However, it is not included in the ColumnEditorFn params interface: https://github.com/xh/hoist-react/blob/2975272a12a559fcfdf710cc7f7d66b4095bd411/cmp/grid/Types.ts#L285-L289

agParams appear to be passed here so should probably just be included as a required property of ColumnEditorFn's params interface: https://github.com/xh/hoist-react/blob/2975272a12a559fcfdf710cc7f7d66b4095bd411/cmp/grid/columns/Column.ts#L980-L993

If we suspect there are times when agParams are not passed, we should make agParams an optional property of EditorProps