search

xhawk18 / promise-cpp

C++ promise/A+ library in Javascript style.
MIT License
672 stars 92 forks source link

use reference on temporarry object #29

Open SmileGobo opened 4 months ago

SmileGobo commented 4 months ago

in call method used trick with potentional UB

https://github.com/xhawk18/promise-cpp/blob/556dce7183dc76a229e5f6f82bd5e7ef1203bbfd/include/promise-cpp/promise_inl.hpp#L206 https://github.com/xhawk18/promise-cpp/blob/556dce7183dc76a229e5f6f82bd5e7ef1203bbfd/include/promise-cpp/promise_inl.hpp#L182 https://github.com/xhawk18/promise-cpp/blob/556dce7183dc76a229e5f6f82bd5e7ef1203bbfd/include/promise-cpp/promise_inl.hpp#L233 https://github.com/xhawk18/promise-cpp/blob/556dce7183dc76a229e5f6f82bd5e7ef1203bbfd/include/promise-cpp/promise_inl.hpp#L235

What do you think about it?