xhawk18 / promise-cpp

C++ promise/A+ library in Javascript style.
MIT License
679 stars 92 forks source link

Add overload to use Defer::then(Defer) with rvalues. #5

Closed pck closed 5 years ago

pck commented 5 years ago

Hello, thank you for sharing your code.

I'd like to call then(f()) with a function that returns a promise. My suggestion is to add an overload for Defer&&, but anything that makes the included test pass is fine with me.

I'd also suggest to provide an "install" target.

Happy new year, Paul

xhawk18 commented 5 years ago

Hi, Paul, thank you for creating this patch!

I built with cmake and got an error -- CMake Error: File promise-cpp/build/promise-cpp.pc.in does not exist. Could you help to check that?

Happy new year! X-Hawk

pck commented 5 years ago

I added the missing file.