xhiroga / aws-peacock-management-console

Browser Extension to show account alias and change color of AWS Management Console, even if AWS SSO.
MIT License
85 stars 10 forks source link

Optional parameter in config JSON to store (1) notes (2) alias override or prefix/suffix #47

Open raghuvv opened 2 years ago

raghuvv commented 2 years ago

Description

add additional optional parameters in config

  1. NOTES - to store notes about the account(s) e.g. for POC of MyApp
  2. ALIAS (override/prefix/suffix) - small text string that will be displayed in place of or in addition to the account alias. E.g. "Sandbox". If possible please include Unicode support.

Other information

No response

Acknowledge

umireon commented 2 years ago

I don't think this should be implemented.

umireon commented 2 years ago

ALIASに関しては絵文字1文字をくっつけられるようにして欲しいのかなとエスパーしました

xhiroga commented 2 years ago

@raghuvv Thank you for your suggestion!

NOTES - to store notes about the account(s) e.g. for POC of MyApp

I have same opinion with @umireon. JSONC format for comment is enough.

ALIAS (override/prefix/suffix)

Could you tell me your problem? In my opinion, account name is enough to distinguish AWS account. When user uses AWS SSO, this extension show account name. Isn't it enough?

raghuvv commented 2 years ago

Re: ALIAS --

Account ALIAS / Account name may ne setup by the AWS account admin based on their own context,

A user may be accessing that AWS account in a different context. Example A vendor / service provider that provides services to multiple clients. Being able to add a prefix / suffix / emoji to the display name of the account may help them easily organize the accounts and separate them.

For instance a consultant might have access to AWS accounts of three different clients -- client1, client2, client3.

Each client would have their own naming convention for aliases. Some clients may have multiple AWS accounts with no standard naming.

But the consultant may still want to tag them clearly for their own reference.

StFS commented 2 months ago

I wholeheartedly agree with the need for an "alias" field.

In my case, my company has multiple different accounts for different environments (live, stable, dev). We also have accounts for different teams (teamA-live, teamA-stable, teamA-dev). I am not an AWS account admin but I am an admin for multiple accounts that I get assigned. All I see currently is "AdministratorAccess" in all the different accounts.

I do see from the header/footer color what "tier" I'm in, but I don't see which account I'm in (for example shared-live vs teamA-live).

So please consider adding an alias field which would then be displayed somewhere in the header or footer (for example below, or even instead of the AWS logo in the upper left corner).

xhiroga commented 2 months ago

@raghuvv and @StFS, thank you for your feedback!

In Peacock Management Console, if you are signed in via AWS SSO, the account alias is automatically displayed in the account menu button.

If you don't mind, could you please let us know the sign-in methods you are using?

I apologize for not fully understanding why this feature is necessary initially. If there are users who use methods other than SSO, it would indeed be convenient to display the account alias in the menu button, and we will consider adding this feature.