I want to be able to switch to a role on the console and still have it work

xhiroga / aws-peacock-management-console

Browser Extension to show account alias and change color of AWS Management Console, even if AWS SSO.

MIT License

81 stars 7 forks source link

I want to be able to switch to a role on the console and still have it work #67

Closed masamaru0513 closed 6 months ago

masamaru0513 commented 11 months ago

Description

It works when accessing via SSO, but not when switching roles from the menu in the upper right corner of the management console.

Motivation

Same as above.

I know how to deal with it. If you like, I can address it and submit a pull request.

Acknowledge

[X] This feature request is based on actual problems that have occurred after using the extension in YOUR practice.
[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

xhiroga commented 11 months ago

@j13158mk

Thank you for your report! I apologize for not noticing the issue myself as I haven't been using the role recently. Pull requests are very welcome and will definitely be reviewed. If I end up making the fix myself, it may take a little while. Thank you for your prompt response!

起票ありがとうございます！私自身がロールを最近使っていないため、問題に気づけず申し訳ありません。 PRは大歓迎ですし、必ずレビューします。私が修正する場合、少しお時間がかかりそうです。取り急ぎお返事させていただきました！

masamaru0513 commented 11 months ago

ありがとうございます。今後対応を予定しますので、その際は確認お願いします。

xhiroga commented 6 months ago

@j13158mk さん、こんにちは。 Issueを修正してみました！（ https://github.com/xhiroga/aws-peacock-management-console/pull/75 ）

よければお試しください。ストアの評価もしていただけると嬉しいです😊 Issueの方はいったんクローズしますが、なにか問題があれば教えて下さいませ🙏

masamaru0513 commented 5 months ago

気づくのが遅くなりました。ご対応ありがとうございます。アイデアはあったのですが手が回らずでした。。ストアも評価入れました。

xhiroga commented 5 months ago

@j13158mk いえいえ！お返事ありがとうございます。今後ともよろしくお願いいたします～！