Export priority type - Githubissues

xhit / go-simple-mail

Golang package for send email. Support keep alive connection, TLS and SSL. Easy for bulk SMTP.

MIT License

650 stars 102 forks source link

Export priority type #83

Closed nikoksr closed 1 year ago

nikoksr commented 1 year ago

Hi @xhit,

thanks for your work on this! Just a quick question regarding the priority type. Is there any reason why it's not exported? It being an unexported type makes it kinda annoying to translate priorities between this and other packages.

If there's a specific reason, please let me know. If not, I got a PR basically ready!

Cheers

xhit commented 1 year ago

Not special reason, can be exported, if you need this ASAP please send a PR, I will take a look soon.

Cheers.

nikoksr commented 1 year ago

Thanks for the quick response! PR is up for you review.

We're utilizing your library in Notify, and making a move from jordan-wright/email to your library and so far, it's been a blast.

xhit commented 1 year ago

Merged.

Cool! I expect this package could help you. About Notify, really cool project, I think will help me in some devops stuff with a planned migration.

Cheers.