xhluca / bm25s

Fast lexical search library implementing BM25 in Python using Numpy and Scipy
https://bm25s.github.io
MIT License
767 stars 31 forks source link

Minor bug: `show_progress` not propagated in `BM25.index` #15

Closed ValeKnappich closed 2 months ago

ValeKnappich commented 2 months ago

Just a minor bug: the show_progress setting is not getting propagated from BM25.index to BM25.build_index_from_ids. Currently __init__.py line 352-356:

            scores = self.build_index_from_ids(
                unique_token_ids=unique_token_ids,
                corpus_token_ids=corpus_token_ids,
                leave_progress=leave_progress
            )

should be

            scores = self.build_index_from_ids(
                unique_token_ids=unique_token_ids,
                corpus_token_ids=corpus_token_ids,
                leave_progress=leave_progress,
                show_progress=show_progress
            )
xhluca commented 2 months ago

Fixed in 0.1.8!