[`compat`] Allow for local install on Windows

[tomaarsen]

Hello!

Pull Request overview

• Allow for local install on Windows

Details

Currently, the open("README.md") in setup.py is complaining on Windows with:

UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 344: character maps to <undefined>

due to some unexpected character somewhere. Specifying the encoding as UTF-8 is a standard way to allow Windows users to open files safely.

Unrelated

Another thing, perhaps you can just do:

from bm25s.version import __version__ as version

rather than

version = {}
with open(f"{package_name}/version.py", encoding="utf8") as fp:
    exec(fp.read(), version)

...

version["__version__"]

Also because I don't like using exec, but it's personal preference.

• Tom Aarsen

[xhluca]

version = {} with open(f"{package_name}/version.py", encoding="utf8") as fp: exec(fp.read(), version) version["version"]

Thanks! You are right that exec is not great. I believe import would fail due to how setup.py is designed, but would need to look into it.