xhorak / firefox-devedition-flatpak

Flatpak manifest and patches to build Firefox
https://firefox-flatpak.mojefedora.cz/
68 stars 28 forks source link

[FirefoxUpstreamBinary] Switch to Freedesktop-19.08 #135

Closed oleid closed 4 years ago

oleid commented 4 years ago

I was also hit by the segfault bug, so I tried to package upstream firefox to flatpak, as flatpak is the only viable option for me on clear-linux to get a featureful ffmpeg. A bare version worked fine. Then I discovered, that you also have this covered in this repository, but with an outdated runtime. Thus, I combined what I had with what you have to build this PR. Hope you find it useful :)

The build works fine for me. It would seem dbus-glibis the only thing which is missing from freedesktop-19.08.

Tested with:

sh ./build_flatpak_from_url http://archive.mozilla.org/pub/firefox/candidates/70.0.1-candidates/build1/linux-x86_64/en-US/firefox-70.0.1.tar.bz2

lionirdeadman commented 4 years ago

Works with Firefox 71 too. Nice!

erAck commented 4 years ago

Current build since commit de981c45bddbf557fcacdc852a4106212b3e290e uses runtime-version 3.34 and dbus-glib from the shared-modules submodule.

What advantage would using Freedestop-19.08 (or later) have?

jbruechert commented 4 years ago

The advantage would probably be a smaller storage footprint for people who don't have the gnome runtime installed. Both, KDE Plasma and GNOME users often have the Freedesktop runtime already installed because it is a dependency of both the KDE and the GNOME runtime.

erAck commented 4 years ago

Works with 75.0b4, thanks!