xhorizont / eepe

Automatically exported from code.google.com/p/eepe
0 stars 0 forks source link

Battery warning value problem #88

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
It seems that there is a rounding problem when storing the value:

What steps will reproduce the problem?
1. File/New
2. Open general settings and set battery Warning to 10,2V
3. Close the general settings editor
4. Open it again: battery warning is now equal to 10,1V !

Original issue reported on code.google.com by capitain...@gmail.com on 27 Feb 2011 at 1:16

GoogleCodeExporter commented 8 years ago
In addition, i don't know if those two things are linked: if i set a limit max. 
of 20 for channel 1 and then i test it with the simulator i observe that i can 
only go to 19,9

That's not critical at all of course, juste a bit disturbing ;-)

Original comment by capitain...@gmail.com on 27 Feb 2011 at 2:11

GoogleCodeExporter commented 8 years ago
You're right on the second count.
It sometimes does not round up correctly.   This is because the background math 
is fixed point rather than floating point.  This is inherently faster but less 
accurate.

I'll look into the battery thing.

Original comment by erezra...@gmail.com on 27 Feb 2011 at 2:25

GoogleCodeExporter commented 8 years ago
Thanks for the explanation.

Original comment by capitain...@gmail.com on 27 Feb 2011 at 3:39

GoogleCodeExporter commented 8 years ago
May i suggest the following modifications (diff patch attached)

Works OK for me on Windows 7 64bits

Original comment by capitain...@gmail.com on 6 Mar 2011 at 12:12

Attachments: