"Choose a root event" interface design issues

[GoogleCodeExporter]

1) Help option should be moved to the Menu.
2) Okay button should be replaced by a click for selection

Original issue reported on code.google.com by case.and...@gmail.com on 20 May 2010 at 4:50

• Blocking: #59

[GoogleCodeExporter]

Original comment by wangchen...@gmail.com on 14 Jun 2010 at 3:44

• Changed state: Started

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I think the cancel button should also be removed since the user can just hit 
the back button. That way, we could make the UI look much cleaner.  If this is 
going to be a huge task, then we should probably create a separate issue for 
the cancel button.

Original comment by renc...@gmail.com on 16 Jun 2010 at 3:45

[GoogleCodeExporter]

Please ignore my previous comment since it was just implemented in r762 
recently.

Original comment by renc...@gmail.com on 21 Jun 2010 at 2:53

[GoogleCodeExporter]

Original comment by case.and...@gmail.com on 22 Jun 2010 at 8:38

• Added labels: Milestone-Release1.0

[GoogleCodeExporter]

Any problems holding you up here?

Original comment by case.and...@gmail.com on 3 Jul 2010 at 5:52

• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

I think:

General Help (if necessary) can be an Option Menu feature and I'll be happy to 
address this in Issue 59.

I think this issue should address Event specific help/info which should 
probably be handled by a Context Menu.

If you disagree or have a different opinion, let's discuss.

Original comment by case.and...@gmail.com on 6 Jul 2010 at 2:50

[GoogleCodeExporter]

Issue 113 has been merged into this issue.

Original comment by case.and...@gmail.com on 8 Jul 2010 at 2:33

[GoogleCodeExporter]

Hello, Wang, have you started doing this? Do you mind if I take over this issue?

Original comment by renc...@gmail.com on 14 Jul 2010 at 3:35

[GoogleCodeExporter]

I am planning to remove the info button in this issue because it seems self 
explanatory in the following screens:

1. Application List (root event > ok > add action)
2. Action List (app list > ok)
3. Filter List (root event > ok > add filter)

What do you guys think?

Original comment by renc...@gmail.com on 15 Jul 2010 at 11:22

[GoogleCodeExporter]

I think the "info" buttons are suppose to be item selection specific.  For 
example...

I select the "Phone is Ringing" event.  Then I select "Add Filter" and it lists 
some filters.  Some of these filters names may not be descriptive enough for 
users to ascertain what that filter is.  So if you click that filter and then 
select the "Info" button it should come up with a longer more helpful 
description for that filter.

I think it's fine to remove right now to just clean up the UI until we add 
longer descriptions, but a new ticket should get made about providing longer 
filter/action descriptions in the future.

This more information button though shouldn't be on a button bar anyway, it 
should be a context menu for each item via longclick selection (similar to how 
I did context menu's addressed in Issue 111.)  The button bar should be removed 
throughout all these dialogs, OK should be replaced by item clicks.

In short:
Remove the button bars, replace with item select for OK.  Open new ticket for 
adding longer filter/action/event descriptions via context menu.

Does that make sense?

Original comment by case.and...@gmail.com on 15 Jul 2010 at 11:35

[GoogleCodeExporter]

I agree with drew. ok button definitely needs to be removed.

I think names are descriptive enough, but having info in context menu is a good 
idea, but it's not so urgent. so if you don't want to address it that's ok. 

Original comment by sv767%ny...@gtempaccount.com on 16 Jul 2010 at 12:15

[GoogleCodeExporter]

I should take a picture to memorialize this event.

Original comment by case.and...@gmail.com on 16 Jul 2010 at 12:31

[GoogleCodeExporter]

Code review:
http://codereview.appspot.com/1664052

Test Cases:
1. Check the ff on the affected screens*:
  1.1 No footer bar. No ok and info button.
  1.2 Clicking an item will let you proceed to the next screen without error (meaning, should behave the same way as clicking the item the clicking ok before the fix).
2. Go to Create rule > select event > add action > select Omnidroid > select 
set phone silent. The new action should be added to the rule.
3. Create a new rule and click the save button. The name and description should 
be empty.
4. Select an exisiting rule and click the save button. The name and description 
should display the saved name and description.
5. Create a new rule and click the save button and try to enter the name and 
description. The name and description should remain even after changing the 
orientation or going to home momentarily and getting back.
6. Go to Create rule > select event > add action > select Twitter > click setup 
account > click the help button. The text should not mention anything about the 
checkbox.

*affected screens:
1. Create rule
2. Create rule > select event > add action
3. Create rule > select event > add action > select app
4. Create rule > select event > add action > select app > select action > 
select control then click attribute
5. Create rule > select event > add filter
6. Create rule > select event > add filter > select filter

Original comment by renc...@gmail.com on 16 Jul 2010 at 2:28

[GoogleCodeExporter]

Checked-in on r816.

Original comment by renc...@gmail.com on 17 Jul 2010 at 3:24

• Changed state: Fixed