xhsyy / omnidroid

Automatically exported from code.google.com/p/omnidroid
Apache License 2.0
1 stars 0 forks source link

Settings Activity #80

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
We need a new activity that handles Settings.  A button should be put on the 
main activity that brings up the setting activity.

Original issue reported on code.google.com by case.and...@gmail.com on 8 Jun 2010 at 10:59

GoogleCodeExporter commented 9 years ago
I will work on this with huangf100

Original comment by chengsh...@gmail.com on 8 Jun 2010 at 11:21

GoogleCodeExporter commented 9 years ago
working on it with Shi.

Original comment by huangf100 on 9 Jun 2010 at 2:09

GoogleCodeExporter commented 9 years ago
Are you planning to use a PreferenceActivity 
(http://developer.android.com/reference/android/preference/PreferenceActivity.ht
ml) and store the preferences in the SharedPreferences class 
(http://developer.android.com/reference/android/content/SharedPreferences.html) 
or in our SQL database?

I'm wondering because I'm planning to store a variable in conjunction with 
Issue28 and I was planning to use the SharedPreferences, but if you are 
incorporating this into the database I may want to follow suit.

Original comment by case.and...@gmail.com on 15 Jun 2010 at 4:37

GoogleCodeExporter commented 9 years ago
Good idea. I haven't noticed the PreferenceActivity before. After one day's 
looking up the reference, we will choose to store the settings in 
SharedPreferences. Thanks.

Original comment by huangf100 on 17 Jun 2010 at 3:36

GoogleCodeExporter commented 9 years ago
No problem.  You can check out my ongoing CodeReview 
(http://codereview.appspot.com/1715041/show) for what I did to implement it.  
Specifically these two files:
  http://codereview.appspot.com/1715041/diff/21001/22006
  http://codereview.appspot.com/1715041/diff/21001/22004

I would appreciate a review too if you have the time.  =)

Original comment by case.and...@gmail.com on 17 Jun 2010 at 5:16

GoogleCodeExporter commented 9 years ago
Fixed.

Here is what has been done:
1. added a options menu at the main screen.
2. added Settings in the options menu.
3. added View Logs in the options menu.

Original comment by huangf100 on 20 Jun 2010 at 2:06

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
This issue was closed by revision r761.

Original comment by huangf100 on 20 Jun 2010 at 2:18

GoogleCodeExporter commented 9 years ago
code review is here:
http://codereview.appspot.com/1695044/show

Original comment by huangf100 on 22 Jun 2010 at 10:31