search

xhsyy / omnidroid

Automatically exported from code.google.com/p/omnidroid
Apache License 2.0
1 stars 0 forks source link

Only show +Filter when appropriate #87

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When adding a new rule, only display the +Filter button if the currently 
selected root event has filters that can be applied to it.  Example:
  Battery is low

Original issue reported on code.google.com by case.and...@gmail.com on 19 Jun 2010 at 11:08

GoogleCodeExporter commented 9 years ago 
Start to look at this issue

Original comment by renc...@gmail.com on 20 Jun 2010 at 1:29

GoogleCodeExporter commented 9 years ago 
Code review:
http://codereview.appspot.com/1721046

Decided to disable the +Filter button instead of hiding it. Also check issue 63 
for the discussion on this matter.

Test cases (Check both from Create Rule and View Rule):
1. Check rules not applicable to filters (like batt is low) that the button is 
disabled.
1. Check rules applicable to filters (like phone ringing) that the button is 
enabled and working.

Original comment by renc...@gmail.com on 23 Jun 2010 at 5:10

GoogleCodeExporter commented 9 years ago 
Checked-in @ r768

Original comment by renc...@gmail.com on 23 Jun 2010 at 10:24