Closed dinosaure closed 1 year ago
So sorry for the delay in responding!
A minor changes was about OPAM files when I decided to remove pin-depends and directly use the same version between
yocaml
and derivations of it (yocaml_*
). I think, such layout about package is better.
I don't know this pattern, which does seem better, is it documented somewhere?
About the PullRequest, a lot of it touches on something I don't know much about and I trust your experience a lot more than my ability to understand it all, so let me ask a few things. The PullRequest is, so far, doing a lot of different things and the CI doesn't seem to be getting through anymore, so would it be possible to split it into several pieces (if only to investigate the CI error more easily and probably simplify the review):
version
. It should be trivial to review and merge very quickly.yocaml_git
package. Which begs the question, is it necessary to delete yocaml_irmin
? I'm not really familiar with all of these tools, but is the maintenance effort between the two packages really that much? (If so, I totally understand wanting to remove irmin
, if not, isn't it worth keeping both?)paf
. conan
. As the aim is to facilitate live file writing, I think the slight loss of performance is not an issue, although in an ideal world one could imagine the server using conan
living in another package.I realise that these are a lot of changes, and you are free to decline to do so, in which case the IC fix will be sufficient and I will try to do a full review as soon as possible. Thanks again for pushing YOCaml so far!
Close because I split this PR to some important pieces which are merged.
This PR has two reasons: 1) I want to lint dependencies for
yocaml_irmin
. Currently, we mainly need something which is able toclone
/push
. In such context, Irmin is a bit bigger than what we really need. Fortunately, Robur did a great projectgit-kv
which does exactly that without the Irmin layer. The real advantage to switch from one to another is the speed (Irmin does many things that we don't really need) and dependencies 2) The second change is the deletion of CoHTTP forpaf
. The last one can handle the H2 protocol (despite CoHTTP) and ALPN. It provides an easy way to make a website with MirageOS (asunipi
.A minor changes was about OPAM files when I decided to remove
pin-depends
and directly use the same version betweenyocaml
and derivations of it (yocaml_*
). I think, such layout about package is better.Finally, I decided to experiment
conan
which allows you to recognize the MIME type of a file as thefile
/libmagic
does (from a database). I updated mydinosaure/blogger
from this PR and everything works like before (but we can notice a regression about link time and performance due toconan
). IF you don't want to useconan
, that's fine, the project still is experimental.