Closed cmyr closed 5 years ago
@mmatoszko @rakaramos @liamrosenfeld maybe one of you would like to give this a look?
Merging #353 into master will decrease coverage by
1.74%
. The diff coverage is47.69%
.
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 45.87% 44.12% -1.75%
==========================================
Files 30 31 +1
Lines 3863 3884 +21
==========================================
- Hits 1772 1714 -58
- Misses 2091 2170 +79
Impacted Files | Coverage Δ | |
---|---|---|
Tests/XiEditorTests/XiCoreTests.swift | 94.62% <100%> (+0.3%) |
:arrow_up: |
Sources/XiEditor/RPCSending.swift | 56.97% <43.33%> (-0.01%) |
:arrow_down: |
Sources/XiEditor/LoggingUtilities.swift | 43.33% <43.33%> (ø) |
|
Sources/XiEditor/EditViewController.swift | 27.41% <0%> (-10.62%) |
:arrow_down: |
Sources/XiEditor/AppDelegate.swift | 36.76% <0%> (-2.95%) |
:arrow_down: |
Sources/XiEditor/XiTextPlane/Atlas.swift | 76.78% <0%> (-1.79%) |
:arrow_down: |
Sources/XiEditor/EditView.swift | 54.44% <0%> (-0.86%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b0e23d9...488b947. Read the comment docs.
This adds a few things:
It still doesn't feel like we handle the core connection very elegantly. It would be nice, for instance, if we showed an alert if core had crashed, maybe with an option to open the log directory. It would also be nice if we were better about how we managed the subprocess's shutdown, in general? We crash pretty hard currently.